-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate PSS from tpke
crate with ferveo
crate
#51
Conversation
# Conflicts: # tpke/src/lib.rs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
aad: &[u8], | ||
validator_decryption_key: &E::Fr, | ||
validator_index: usize, | ||
g_inv: &E::G1Prepared, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passing this as a param feels weird. Can we get it from a context or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It also felt weird to me, but the context is not really used in ferveo
. Maybe I could pass a DKG instance / DKG params instance here instead.
dkg.params.security_threshold as usize, | ||
&Fr::zero(), | ||
rng, | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This assumes we have a single dealer. Is there a test with N dealers and an aggregated update polynomial?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There isn't one, but it's definitely worthwhile. I can add it to this or another PR.
Will address PR comments in future PRs (#73) |
tpke
withferveo
crate #40tpke
crate intoferveo
cratetpke
methodsferveo
ferveo
crate #56