Integrate PSS from tpke crate with ferveo crate
#51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotr-roslaniec
changed the base branch from
validity-checks
to
verify-simple-tdec-shares
# Conflicts: # tpke/src/lib.rs
This was referenced Feb 1, 2023
cygnusv
reviewed
Feb 20, 2023
| aad: &[u8], | ||
| validator_decryption_key: &E::Fr, | ||
| validator_index: usize, | ||
| g_inv: &E::G1Prepared, |
There was a problem hiding this comment.
Passing this as a param feels weird. Can we get it from a context or something?
There was a problem hiding this comment.
It also felt weird to me, but the context is not really used in ferveo. Maybe I could pass a DKG instance / DKG params instance here instead.
| dkg.params.security_threshold as usize, | ||
| &Fr::zero(), | ||
| rng, | ||
| ); |
There was a problem hiding this comment.
This assumes we have a single dealer. Is there a test with N dealers and an aggregated update polynomial?
There was a problem hiding this comment.
There isn't one, but it's definitely worthwhile. I can add it to this or another PR.
cygnusv
approved these changes
Feb 22, 2023
|
Will address PR comments in future PRs (#73) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tpkewithferveocrate #40tpkecrate intoferveocratetpkemethodsferveoferveocrate #56